Use URI formatters for "Copy Call Stack" (fixes #224685) #224686
Closed
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Oct 3, 2024
| const labelFormatter3 = (uri: URI) => { return `!${uri.fsPath}`; }; | ||
| const thirdSource = new Source({ name: "module.js", path: "val\\module.js" }, 'aDebugSessionId', mockUriIdentityService, new NullLogService()); | ||
| const stackFrame3 = new StackFrame(thread, 2, thirdSource, 'module', 'normal', { startLineNumber: undefined!, startColumn: undefined!, endLineNumber: undefined!, endColumn: undefined! }, 2, true); | ||
| assert.strictEqual(stackFrame3.toString(labelFormatter3), 'mmmodule.js:1'); |
Member
There was a problem hiding this comment.
This test is failing, but I'm not sure what you intended, can you look at it? Did you mean for the label formatter to be called?
roblourens
reviewed
Oct 3, 2024
Member
roblourens
left a comment
There was a problem hiding this comment.
Thanks for the PR, sorry for the slow response. Just one question on the unit test
Member
|
Seems stale |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #224685