fix: memory leak in SelectBoxList #221507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in
SelectBoxListby registeringthis.selectListto the disposable store.Event listeners (before)
When opening and closing the select box in the output view 97 times, the number of event listeners increases by 194 or 388:
{ "eventListenersWithStackTrace": [ { "type": "click", "description": "(e) => this.emitter.fire(e)", "objectId": "7028190583252114818.4.54457", "stack": [ "listener (vscode/out/vs/base/browser/event.js:13:23)", "Object.onWillAddFirstListener (vscode/out/vs/base/browser/event.js:16:55)", "_event (vscode/out/vs/base/common/event.js:856:60)", "vscode/out/vs/base/common/event.js:102:73", "Object.onWillAddFirstListener (vscode/out/vs/base/common/event.js:155:32)", "_event (vscode/out/vs/base/common/event.js:856:60)", "vscode/out/vs/base/common/event.js:133:95", "Array.map (<anonymous>)", "vscode/out/vs/base/common/event.js:133:82", "new MouseController (vscode/out/vs/base/browser/ui/list/listWidget.js:573:86)", "List.createMouseController (vscode/out/vs/base/browser/ui/list/listWidget.js:1195:20)", "new List (vscode/out/vs/base/browser/ui/list/listWidget.js:1180:41)", "SelectBoxList.createSelectList (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:576:31)", "SelectBoxList.showSelectDropDown (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:354:18)", "HTMLSelectElement.<anonymous> (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:166:26)" ], "count": 388, "originalStack": ["vscode/src/vs/base/browser/event.ts:40:14"], "originalName": null }, { "type": "keydown", "description": "(e) => this.emitter.fire(e)", "objectId": "7028190583252114818.4.54455", "stack": [ "listener (vscode/out/vs/base/browser/event.js:13:23)", "Object.onWillAddFirstListener (vscode/out/vs/base/browser/event.js:16:55)", "_event (vscode/out/vs/base/common/event.js:856:60)", "fn (vscode/out/vs/base/common/event.js:396:24)", "fn (vscode/out/vs/base/common/event.js:396:24)", "new DOMFocusController (vscode/out/vs/base/browser/ui/list/listWidget.js:513:13)", "new List (vscode/out/vs/base/browser/ui/list/listWidget.js:1170:34)", "SelectBoxList.createSelectList (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:576:31)", "SelectBoxList.showSelectDropDown (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:354:18)", "HTMLSelectElement.<anonymous> (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:166:26)" ], "count": 194, "originalStack": ["vscode/src/vs/base/browser/event.ts:40:14"], "originalName": null }, { "type": "auxclick", "description": "(e) => this.emitter.fire(e)", "objectId": "7028190583252114818.4.54459", "stack": [ "listener (vscode/out/vs/base/browser/event.js:13:23)", "Object.onWillAddFirstListener (vscode/out/vs/base/browser/event.js:16:55)", "_event (vscode/out/vs/base/common/event.js:856:60)", "vscode/out/vs/base/common/event.js:102:73", "Object.onWillAddFirstListener (vscode/out/vs/base/common/event.js:155:32)", "_event (vscode/out/vs/base/common/event.js:856:60)", "vscode/out/vs/base/common/event.js:121:73", "Object.onWillAddFirstListener (vscode/out/vs/base/common/event.js:155:32)", "_event (vscode/out/vs/base/common/event.js:856:60)", "vscode/out/vs/base/common/event.js:133:95", "Array.map (<anonymous>)", "vscode/out/vs/base/common/event.js:133:82", "new MouseController (vscode/out/vs/base/browser/ui/list/listWidget.js:573:86)", "List.createMouseController (vscode/out/vs/base/browser/ui/list/listWidget.js:1195:20)", "new List (vscode/out/vs/base/browser/ui/list/listWidget.js:1180:41)", "SelectBoxList.createSelectList (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:576:31)", "SelectBoxList.showSelectDropDown (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:354:18)", "HTMLSelectElement.<anonymous> (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:166:26)" ], "count": 194, "originalStack": ["vscode/src/vs/base/browser/event.ts:40:14"], "originalName": null } ] }Event listeners (after)
The number of event listeners stays basically constant:
{ "eventListenersWithStackTrace": [ { "type": "blur", "description": "(e)=>{\n this.onDOMEvent(e, false);\n }", "objectId": "-6731368636718759049.4.37375", "sourceMaps": [""], "stack": [ "listener (vscode/out/vs/base/browser/ui/contextview/contextview.js:210:106)", "new DomListener (vscode/out/vs/base/browser/dom.js:516:24)", "addDisposableListener (vscode/out/vs/base/browser/dom.js:528:16)", "Object.addStandardDisposableListener (vscode/out/vs/base/browser/dom.js:547:16)", "vscode/out/vs/base/browser/ui/contextview/contextview.js:211:54", "Array.forEach (<anonymous>)", "ContextView.setContainer (vscode/out/vs/base/browser/ui/contextview/contextview.js:210:46)", "ContextViewService.showContextView (vscode/out/vs/platform/contextview/browser/contextViewService.js:59:30)", "SelectBoxList.showSelectDropDown (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:360:38)", "HTMLSelectElement.<anonymous> (vscode/out/vs/base/browser/ui/selectBox/selectBoxCustom.js:192:26)" ], "count": 2 }, { "type": "-monaco-gesturesend", "description": "(e)=>{\n e.preventDefault();\n e.stopPropagation();\n this._gestureInProgress = false;\n this._slider.toggleClassName('active', false);\n }", "objectId": "-6731368636718759049.4.37363", "sourceMaps": [""], "stack": [ "listener (vscode/out/vs/editor/browser/viewParts/minimap/minimap.js:928:123)", "new DomListener (vscode/out/vs/base/browser/dom.js:516:24)", "addDisposableListener (vscode/out/vs/base/browser/dom.js:528:16)", "Object.addStandardDisposableListener (vscode/out/vs/base/browser/dom.js:547:16)", "new InnerMinimap (vscode/out/vs/editor/browser/viewParts/minimap/minimap.js:929:49)", "new Minimap (vscode/out/vs/editor/browser/viewParts/minimap/minimap.js:569:28)", "new View (vscode/out/vs/editor/browser/view.js:174:29)", "CodeEditorWidget._createView (vscode/out/vs/editor/browser/widget/codeEditor/codeEditorWidget.js:1545:26)", "CodeEditorWidget._attachModel (vscode/out/vs/editor/browser/widget/codeEditor/codeEditorWidget.js:1442:46)", "CodeEditorWidget.setModel (vscode/out/vs/editor/browser/widget/codeEditor/codeEditorWidget.js:457:22)", "OutputEditor.setInput (vscode/out/vs/workbench/browser/parts/editor/textResourceEditor.js:70:21)", "async OutputEditor.setInput (vscode/out/vs/workbench/contrib/output/browser/outputView.js:258:13)" ], "count": 1 }, { "type": "-monaco-gesturechange", "description": "(e)=>{\n e.preventDefault();\n e.stopPropagation();\n if (this._lastRenderData && this._gestureInProgress) {\n this.scrollDueToTouchEvent(e);\n }\n }", "objectId": "-6731368636718759049.4.37361", "sourceMaps": [""], "stack": [ "listener (vscode/out/vs/editor/browser/viewParts/minimap/minimap.js:919:119)", "new DomListener (vscode/out/vs/base/browser/dom.js:516:24)", "Object.addDisposableListener (vscode/out/vs/base/browser/dom.js:528:16)", "new InnerMinimap (vscode/out/vs/editor/browser/viewParts/minimap/minimap.js:920:50)", "new Minimap (vscode/out/vs/editor/browser/viewParts/minimap/minimap.js:569:28)", "new View (vscode/out/vs/editor/browser/view.js:174:29)", "CodeEditorWidget._createView (vscode/out/vs/editor/browser/widget/codeEditor/codeEditorWidget.js:1545:26)", "CodeEditorWidget._attachModel (vscode/out/vs/editor/browser/widget/codeEditor/codeEditorWidget.js:1442:46)", "CodeEditorWidget.setModel (vscode/out/vs/editor/browser/widget/codeEditor/codeEditorWidget.js:457:22)", "OutputEditor.setInput (vscode/out/vs/workbench/browser/parts/editor/textResourceEditor.js:70:21)", "async OutputEditor.setInput (vscode/out/vs/workbench/contrib/output/browser/outputView.js:258:13)" ], "count": 1 } ] }