Reset shell-type context when the type is unknown #221277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To provide robust usage upon shell type context, only set shell-type context key if we can tell the type of the shell.
Also update the description of the context to reflect this change.
This modification resolve #191650.
Since that the semantic of the context key is also changed, the translation should also be updated.
But I'm not sure about the work flow regarding this.
How to Test
(This PR can only be verified since that
terminalShellTypecontext key is only supported when the host environment is Windows.)Prepare a shell profile that the shell type is undefined.
Open a shell, inspect the context key
terminalShellTypeis set correctly.Open another shell that do not support shell-type,
inspect again to check that the context key
terminalShellTypeis disappeared.(Also change between two opened shells to validate the behavior)