-
Notifications
You must be signed in to change notification settings - Fork 37k
Make Inlay hint length configurable #221276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Inlay hint length configurable #221276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is already looking great but it got me thinking if the current approach of limiting inlay hints length against the overall length of all hints for a line should be revisited. Later hints do get penalised by longer former hints and maybe that's a source of confusion? Meaning there could be two values: one limits the length of each hint and an overall limit or a generally smarter way of trimming. E.g trim a little of each inlay hint so that later once get a chance to be shown. wdyt?
This comment was marked as abuse.
This comment was marked as abuse.
|
@rafamerlin Thanks for staying with me for so long. I updated this PR with main and it is now ready to be merged. I also pushed some little fixed and changed my mind and simplified this to a single setting again. I believe, for now, most folks will use this to disable trimming anyways |
Solves #205708
This will let us define how long we want the hints, I use rust quite a bit and rely a lot on this, the 43 limit was quite small so I made it configurable, examples: