Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@rafamerlin
Copy link
Contributor

Solves #205708

This will let us define how long we want the hints, I use rust quite a bit and rely a lot on this, the 43 limit was quite small so I made it configurable, examples:

image
image

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is already looking great but it got me thinking if the current approach of limiting inlay hints length against the overall length of all hints for a line should be revisited. Later hints do get penalised by longer former hints and maybe that's a source of confusion? Meaning there could be two values: one limits the length of each hint and an overall limit or a generally smarter way of trimming. E.g trim a little of each inlay hint so that later once get a chance to be shown. wdyt?

src/vs/editor/common/config/editorOptions.ts Outdated Show resolved Hide resolved
src/vs/editor/common/config/editorOptions.ts Outdated Show resolved Hide resolved
@jrieken jrieken added this to the August 2024 milestone Jul 11, 2024
@rafamerlin rafamerlin requested a review from jrieken July 11, 2024 12:59
@jrieken jrieken modified the milestones: August 2024, September 2024 Aug 26, 2024
@rafamerlin

This comment was marked as abuse.

@jrieken
Copy link
Member

jrieken commented Sep 2, 2024

@rafamerlin Thanks for staying with me for so long. I updated this PR with main and it is now ready to be merged. I also pushed some little fixed and changed my mind and simplified this to a single setting again. I believe, for now, most folks will use this to disable trimming anyways

@jrieken jrieken enabled auto-merge September 2, 2024 15:28
@jrieken jrieken merged commit 86dc21a into microsoft:main Sep 2, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.