-
Notifications
You must be signed in to change notification settings - Fork 37k
refactor: merge same namespace declaration #219638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: merge same namespace declaration #219638
Conversation
|
@microsoft-github-policy-service agree |
|
@meganrogge hi, could you have a look for this pr? ^_^ I used In my opinion, it could be better that we merge namespaces manually because of gaining better readability for this module, meanwhile, this pr will reduce possibility of emitting errors by some tools like |
|
Hi @Cecil0o0 I'm not sure I understand the problem or what this PR does. Could you pls clarify in the description? |
Hi @meganrogge, Here is background: I wrote a program to transform module code from vscode codebase, after I executed the program, got a error above. when I saw this error, I opened the file with vscode, found two same namespace export which is |
|
@lramos15 Hi ^_^, could you please tell me why |

export same two namespace in a module seems to be mis-understanding while contributors reading this module, this pr would like to solve this.