Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@gjsjohnmurray
Copy link
Contributor

Command Palette was listing three Local History commands despite the feature being disabled. The ... menu of Timeline view also offered one.

My PR corrects this.

@gjsjohnmurray
Copy link
Contributor Author

@bpasero is this PR uncontroversial enough to be merged?

@bpasero bpasero added this to the July 2024 milestone Jul 4, 2024
@bpasero
Copy link
Member

bpasero commented Jul 4, 2024

Thanks, technically local history is still functional even when this setting is disabled, we just stop creating new local history entries. But I don't mind having a way to disable the UI as well when this is configured.

@bpasero bpasero merged commit 859a094 into microsoft:main Jul 4, 2024
@gjsjohnmurray gjsjohnmurray deleted the gold-cricket branch July 4, 2024 08:34
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this pull request Jul 10, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.