Add viewContainer contribution point #212499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thegecko <rob.moran@arm.com>
Member
|
It this be |
jrieken
previously requested changes
Jul 2, 2024
src/vs/workbench/services/extensions/common/extensionsApiProposals.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
I've renamed this to Readme and example updated to reflect the changes above. |
Member
|
Discussed with @jrieken earlier, pushed a change to require that this contribution point only apply to the debug view container, for now. Also, the proposal is mentioning "context menus" but this is only about the title menu, right? I'm renaming the proposal, but otherwise this is ready for Insiders :) |
roblourens
approved these changes
Jul 31, 2024
Tyriar
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #200880 we are keen to add a contribution point to the debug viewlet.
This proposal implements this as well as allowing contributions to other view containers.
To use this proposal, the
package.jsonwould look similar to:{ ... "enabledApiProposals": [ "viewContainerContext" ], "contributes": { "commands": [ { "command": "proposed.dummyMenu", "title": "Dummy Menu", "icon": "$(beaker)" } ], "menus": { "viewContainer/title": [ { "command": "proposed.dummyMenu", "group": "navigation", "when": "viewContainer == workbench.view.debug" } ] } }, ...An example can be found here: https://github.com/thegecko/vscode-proposed-debug
Partially fixes: #200880