Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

added voice chat listening duration feature #197801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpasero merged 7 commits into from
Nov 10, 2023
Merged

added voice chat listening duration feature #197801

bpasero merged 7 commits into from
Nov 10, 2023

Conversation

@PrathamLalwani
Copy link
Contributor

@PrathamLalwani PrathamLalwani commented Nov 9, 2023 •
edited
Loading

I added the requested feature to either disable or increase the length of voice input duration, for this issue #197464.

image

Although I have implemented the said feature I couldn't have tested it because there is no microphone option when building locally.

@PrathamLalwani
Copy link
Contributor Author

PrathamLalwani commented Nov 9, 2023

@PrathamLalwani please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@bpasero bpasero added this to the November 2023 milestone Nov 9, 2023
bpasero
bpasero requested changes Nov 9, 2023
View reviewed changes
src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts Outdated Show resolved Hide resolved
@PrathamLalwani
Copy link
Contributor Author

PrathamLalwani commented Nov 9, 2023

I have changed the mentioned lines and I have done it so in a way that in future more options can be added easily.

@bpasero bpasero self-requested a review November 9, 2023 18:17
@bpasero bpasero enabled auto-merge (squash) November 10, 2023 14:07
bpasero
bpasero approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bpasero bpasero merged commit 358b12e into microsoft:main Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@bpasero bpasero

Labels

None yet

Projects

None yet

Milestone

November 2023

Development

Successfully merging this pull request may close these issues.

3 participants

@PrathamLalwani @joaomoreno @bpasero
Morty Proxy This is a proxified and sanitized view of the page, visit original site.