Avoid empty or ambiguous repository label in Repositories submenu (fix #196613) #196623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/assign @lszomoru |
Contributor
Author
|
I made the minimally disruptive change, but arguably all menu items should use label rather than basename because it's possible for a multiroot workspace to yield more than one repository entry with the same basename. |
Contributor
Author
|
Based on this example, I'm changing the PR to make the label always get used for this submenu.
|
Contributor
Author
|
Now: |
Member
|
@gjsjohnmurray, thank you very much for your contribution. I have pushed a commit to fix some compilation errors, as well as I pushed a change so that the name is computed only once (since |
label if name is undefined
Contributor
Author
|
@lszomoru thanks for the improvements. It's passed my testing, so please get the PR approved and merged. |
lszomoru
approved these changes
Nov 21, 2023
chrmarti
approved these changes
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #196613
Using the repro provided on the issue, the new result is: