Remove redundant task system message and early return affecting FSPs (fix #192490) #196247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/assign @meganrogge |
meganrogge
approved these changes
Oct 30, 2023
Contributor
|
Thank you @gjsjohnmurray |
aeschli
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #192490
At the time #168209 fixed #164051
_computeTasksForSingleConfigpermittedworkspaceFolderto be passed undefined. Since 42e9acc that is no longer the case, so I have removed what #168209 added, which in any case was incorrect as it adversely impacted FileSystemProviders (their schemas don't have dedicated task systems).