Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Sidebail
Copy link
Contributor

@Sidebail Sidebail commented May 4, 2023

Fixes #181435

Previously relative file links were not working properly.

Now whenever in VS Code editor the file link is formatted in a style like
file://../folderName/.../fileName.txt
the code will take the folder of opened file as a starting point, determine where it needs to go, given the names of folders and dots in the file link path and navigate the user to the proper file. Useful!

To test it open any code file and write a link in the format described above in any comment.

@Sidebail
Copy link
Contributor Author

Sidebail commented May 4, 2023

@microsoft-github-policy-service agree

@Sidebail
Copy link
Contributor Author

Sidebail commented May 11, 2023

It's been around a week, so, out of curiosity...
Is it blocked for now? Like, I'm seeing "Need PR Community Approvals" and I'm not really getting who should review that change. A collaborator, a microsoft employee?

It's my first time commiting in this repo, so I'm a bit curious what the process of pull request reviews is. Not to rush anyone, I suspect there are a bunch of other priority tasks lying around, with which I wish the best of luck \(゚ー゚\) @alexdima

@lramos15
Copy link
Member

It's been around a week, so, out of curiosity...
Is it blocked for now? Like, I'm seeing "Need PR Community Approvals" and I'm not really getting who should review that change. A collaborator, a microsoft employee?

It's not blocked, just as you see we have over 5,000 open issues and about 400 open PRs so it takes some time to get around to things. That check is to just ensure external PRs receive 2 reviews from Microsoft Employees. Alex who owns the feature area will give one and then someone else will come an double check.

@Sidebail
Copy link
Contributor Author

It's been around a week, so, out of curiosity...
Is it blocked for now? Like, I'm seeing "Need PR Community Approvals" and I'm not really getting who should review that change. A collaborator, a microsoft employee?

It's not blocked, just as you see we have over 5,000 open issues and about 400 open PRs so it takes some time to get around to things. That check is to just ensure external PRs receive 2 reviews from Microsoft Employees. Alex who owns the feature area will give one and then someone else will come an double check.

Eeey, thanks for answering! Okay, great to hear 👍
Really love how stuff is organized and automated around here

@alexdima alexdima added this to the August 2023 milestone Jul 26, 2023
@alexdima alexdima self-requested a review August 31, 2023 07:43
@alexdima alexdima modified the milestones: August 2023, September 2023 Aug 31, 2023
@alexdima alexdima modified the milestones: September 2023, October 2023 Sep 29, 2023
@alexdima alexdima modified the milestones: October 2023, November 2023 Oct 27, 2023
@alexdima alexdima modified the milestones: November 2023, December 2023 Nov 30, 2023
@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@Challanger524
Copy link

Hooow looong we need to wait? This is so ridiculous 😕

Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexdima alexdima enabled auto-merge (squash) March 20, 2024 20:05
@alexdima alexdima merged commit 5af7860 into microsoft:main Mar 20, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relative file links in comments do not work anymore

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.