-
Notifications
You must be signed in to change notification settings - Fork 37k
Fix file relative path link #181475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file relative path link #181475
Conversation
|
@microsoft-github-policy-service agree |
|
It's been around a week, so, out of curiosity... It's my first time commiting in this repo, so I'm a bit curious what the process of pull request reviews is. Not to rush anyone, I suspect there are a bunch of other priority tasks lying around, with which I wish the best of luck \(゚ー゚\) @alexdima |
It's not blocked, just as you see we have over 5,000 open issues and about 400 open PRs so it takes some time to get around to things. That check is to just ensure external PRs receive 2 reviews from Microsoft Employees. Alex who owns the feature area will give one and then someone else will come an double check. |
Eeey, thanks for answering! Okay, great to hear 👍 |
|
Hooow looong we need to wait? This is so ridiculous 😕 |
alexdima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #181435
Previously relative file links were not working properly.
Now whenever in VS Code editor the file link is formatted in a style like
file://../folderName/.../fileName.txtthe code will take the folder of opened file as a starting point, determine where it needs to go, given the names of folders and dots in the file link path and navigate the user to the proper file. Useful!
To test it open any code file and write a link in the format described above in any comment.