Add close button to SCM editor validation message (#143036) #158131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/assign @lszomoru |
Member
|
I like this approach. @misolori ,@daviddossett, what do you think? |
Contributor
|
I was going to file an issue about this because I couldn't reach the submit button :D We should also add this in the other areas we use the validation, but this looks good to me. |
Member
|
@misolori, do you have a list of the other places where we use validation? |
Contributor
|
@lszomoru I know in Search, Settings UI, and file rename in the explorer |
lszomoru
approved these changes
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #143036