Avoid holding on to NodeBuilder in checker #1289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 424e767.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how NodeBuilder and its emit context are managed by the Checker to avoid retaining large AST nodes in long-lived builder instances. Instead of a single persistent builder, fresh instances are created on each use (with a cached builder only during a checkSourceFile run), allowing unused nodes to be garbage‐collected and addressing the memory/performance issue reported in #988.
- Replace all uses of
c.nodeBuilderandc.diagnosticConstructionContextinprinter.gowith calls toc.getNodeBuilder()and itsEmitContext(). - Introduce
Checker.getNodeBuilder()innodebuilder.goto return either a cached builder (duringcheckSourceFile) or a new builder each time. - Remove
diagnosticConstructionContextandnodeBuilderfields fromCheckerinchecker.go, and instrumentinCheckSourceFileto manage the builder cache lifecycle.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/checker/printer.go | Swapped persistent builder/context for local getNodeBuilder() calls and updated printer creation. |
| internal/checker/nodebuilder.go | Added Checker.getNodeBuilder() method that conditionally reuses or creates a NodeBuilder. |
| internal/checker/checker.go | Removed old builder/context fields, added inCheckSourceFile flag and cache field, and updated lifecycle in checkSourceFile. |
|
Somewhat related question - do node builders use pooled allocators the same way the parser does? |
|
Yes, they do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holding onto the builder, the emit context, and therefore NodeFactory, holds onto a load of old nodes permanently. Create these fresh each time and let them get GC'd rather than try and manually clear everything.
As an optimization, reuse the same builder while checking the same file.For a perf problem found in #988.