Pool commentState allocations #1286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a commentStatePool to reuse commentState instances and significantly reduce allocations when printing. It replaces direct allocations of commentState with pooled instances in various emitComments methods.
- Added a
core.Pool[commentState]field toPrinter - Updated
emitCommentsBeforeNodeto retrieve and initialize a pooledcommentState - Switched
emitCommentsBeforeTokenandemitCommentsAfterTokento use pooled instances instead of fresh allocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These comment states appear to be one of the main allocators when emitting the VS Code codebase. Pool them within a print run.
Reduces the VS Code alloc count from
36015276to28140625(20% reduction).