-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Ignore OSC 7 notifications if host name is not terminal host? #20072
Copy link
Copy link
Open
Labels
Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsNeeds-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting
Description
I've not read through all of #8214 and #3158,
but in the recently added support for OSC 7, it looks like when we receive file://someremoteserver/tmp, we set the working directory for new tabs to /tmp.
This is wrong, because new tabs are opened on the local system.
We should check that it matches (the equivalent of) gethostname() and some other cases, see foot source code for example.
cc @lhecker (I wanted to comment on the commit directly but can't right now for some reason (at least when using the Web UI)).
See also:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsNeeds-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting