fix: HDFStore Resource Leak in DiskDatasetCache#2202
Open
Sagar-py wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
Sagar-py:fix/hdfstore-resource-leakSagar-py/qlib:fix/hdfstore-resource-leakCopy head branch name to clipboard
Open
fix: HDFStore Resource Leak in DiskDatasetCache#2202Sagar-py wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom Sagar-py:fix/hdfstore-resource-leakSagar-py/qlib:fix/hdfstore-resource-leakCopy head branch name to clipboard
Sagar-py wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
Sagar-py:fix/hdfstore-resource-leakSagar-py/qlib:fix/hdfstore-resource-leakCopy head branch name to clipboard
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace manual
pd.HDFStoreopen/close with a context manager inDiskDatasetCache.update()(qlib/data/cache.py)Motivation and Context
The previous pattern relied on an explicit
store.close()call that was never reached if any intermediate operation raised an exception. This leaked file descriptors and could leave the cache file in a partially-written corrupted state - making it all subsequent reads from that cache fail until the file was manually removed.How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Types of changes