fix: pass --interval from BaseRun to Normalize in normalize_data#2200
Open
zhaochaofeng wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
Open
fix: pass --interval from BaseRun to Normalize in normalize_data#2200zhaochaofeng wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
zhaochaofeng wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
Conversation
Fire CLI consumes --interval for BaseRun.__init__ but does not forward it to the Normalize constructor, causing PitNormalize to always default to "quarterly" format regardless of the --interval flag. Co-Authored-By: Claude Opus 4.6 <noreply@openclaude.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where the Fire CLI consumed the
--intervalparameter forBaseRun.__init__but did not forward it to theNormalizeconstructor.Added
intervalparameter passing to ensurePitNormalizeuses the user-provided interval value instead of defaulting to "quarterly".Motivation and Context
The CLI flag
--intervalwas not being passed to the normalization component, causingPitNormalizeto always use the default "quarterly" format regardless of user input.This PR ensures the interval configuration works correctly in the data normalization workflow.
How Has This Been Tested?
python qlib/scripts/data_collector/pit/collector.py normalize_data
--interval annual
--source_dir "
/.qlib/qlib_data/custom_data_hfq/pit_annual"/.qlib/qlib_data/custom_data_hfq/pit_normalized_annual"--normalize_dir "
Types of changes