fix(model): replace mutable default evals_result=dict() with None across 27 models#2168
Open
warren618 wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
warren618:fix/mutable-default-evals-resultwarren618/qlib:fix/mutable-default-evals-resultCopy head branch name to clipboard
Open
fix(model): replace mutable default evals_result=dict() with None across 27 models#2168warren618 wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom warren618:fix/mutable-default-evals-resultwarren618/qlib:fix/mutable-default-evals-resultCopy head branch name to clipboard
warren618 wants to merge 1 commit intomicrosoft:mainmicrosoft/qlib:mainfrom
warren618:fix/mutable-default-evals-resultwarren618/qlib:fix/mutable-default-evals-resultCopy head branch name to clipboard
Conversation
…oss 27 models Using dict() as a default argument is a well-known Python antipattern: the dict is created once at function definition time and shared across all calls. This can cause state leakage between separate fit() calls. Changed all 27 affected models in qlib/contrib/model/ to use evals_result=None with an explicit guard, matching the pattern already used in gbdt.py and highfreq_gdbt_model.py.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2167
27 models use
evals_result=dict()as a mutable default argument infit(). Changed toevals_result=Nonewith explicit guard, matching the pattern ingbdt.py.Changes
For each of the 27 affected files:
27 files changed, 81 insertions, 27 deletions.