This repository was archived by the owner on Apr 14, 2022. It is now read-only.
[WIP]: Split analysis into several assemblies#441
Closed
MikhailArkhipov wants to merge 30 commits into
microsoft:mastermicrosoft/python-language-server:masterfrom
MikhailArkhipov:analysis3Copy head branch name to clipboard
Closed
[WIP]: Split analysis into several assemblies#441MikhailArkhipov wants to merge 30 commits intomicrosoft:mastermicrosoft/python-language-server:masterfrom MikhailArkhipov:analysis3Copy head branch name to clipboard
MikhailArkhipov wants to merge 30 commits into
microsoft:mastermicrosoft/python-language-server:masterfrom
MikhailArkhipov:analysis3Copy head branch name to clipboard
Conversation
added 28 commits
November 14, 2018 15:15
Contributor
|
Ok, I'll have a huge merge for this... |
Author
|
No, if this go in, it will happen after earlier PR which is intended for after your imports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #257
Microsoft.Python.Core- common objects usable in many placesMicrosoft.Python.Parsing- Python parser and ASTMicrosoft.Python.Analysis.Engine- current DDG analysisMicrosoft.Python.Analysis.Ast- AST analysisReasoning: TDD development of the AST based analysis. Having separate assembly for AST analysis allows development of the DDG replacement without having to remove DDG first. DDG can continue to be used until we have sufficient test bed for the AST analysis to prove it is ready for the prime time.
Based on #439.
Still TODO: separate fluent classes for AST analysis since current one use definitions specific to DDG. Therefore tests for both AST and DDG analysis may have to stay in the same assembly for a while.