Allow TaskFailedError to be constructed from Exception#99
Merged
andystaples merged 5 commits intomainmicrosoft/durabletask-python:mainfrom Jan 8, 2026
andystaples/improve-task-failure-logicmicrosoft/durabletask-python:andystaples/improve-task-failure-logicCopy head branch name to clipboard
Merged
Allow TaskFailedError to be constructed from Exception#99andystaples merged 5 commits intomainmicrosoft/durabletask-python:mainfrom andystaples/improve-task-failure-logicmicrosoft/durabletask-python:andystaples/improve-task-failure-logicCopy head branch name to clipboard
andystaples merged 5 commits intomainmicrosoft/durabletask-python:mainfrom
andystaples/improve-task-failure-logicmicrosoft/durabletask-python:andystaples/improve-task-failure-logicCopy head branch name to clipboard
Conversation
4 tasks
andystaples
commented
Jan 7, 2026
larohra
reviewed
Jan 7, 2026
| if self._exception is None: | ||
| raise ValueError('The task has not failed.') | ||
| return self._exception | ||
|
|
There was a problem hiding this comment.
Can we add another override here for failing a task that automatically takes in an Exception and handles all internal things needed by DurableTask to ensure that the failure is handled correctly?
Example:
def fail(self, ex: Exception):
self._is_complete = True
self._exception = TaskFailedError(
"Error occured",
ex
)
if self._parent is not None:
self._parent.on_child_completed(self)
Contributor
Author
There was a problem hiding this comment.
I have updated the signature of CompletableTask.fail() to allow Exceptions as input, it'll handle things from there.
Choosing not to add an implementation of fail() to Task, as it violates the design of having CompletableTask vs CompositeTask. If an externally-defined class inheriting from CompositeTask needs to call fail(), it can double-inherit from CompletableTask (which more correctly describes the behavior of that task anyway).
berndverst
approved these changes
Jan 8, 2026
berndverst
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improves new_failure_details to allow capturing inner exceptions