Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add generic type safety hints #92

Copy link
Copy link
@larohra

Description

@larohra
Issue body actions

The package is lacking type safety in a bunch of places which are causing partially unknown type safety warnings -

Type of "schedule_new_orchestration" is partially unknown
  Type of "schedule_new_orchestration" is "(orchestrator: ((OrchestrationContext, TInput@schedule_new_orchestration) -> (Generator[Task[Unknown], Any, TOutput@schedule_new_orchestration] | TOutput@schedule_new_orchestration)) | str, *, input: TInput@schedule_new_orchestration | None = None, instance_id: str | None = None, start_at: datetime | None = None, reuse_id_policy: OrchestrationIdReusePolicy | None = None, tags: dict[str, str] | None = None, version: str | None = None) -> str"

Though they're not affecting runtime stability, its good to have clean type hints to ensure Pylance can always infer hints cleanly in any environment.

Sample PR with some changes - #91
It would be great to see generic type-hints for all functions.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.