Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Harden put functions against misuse#986

Merged
kennykerr merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
putmicrosoft/cppwinrt:putCopy head branch name to clipboard
Jul 21, 2021
Merged

Harden put functions against misuse#986
kennykerr merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
putmicrosoft/cppwinrt:putCopy head branch name to clipboard

Conversation

@kennykerr
Copy link
Collaborator

The put_abi functions are already hardened in this way.

Copy link
Contributor

@sylveon sylveon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually how I would expect put() to behave.

@kennykerr
Copy link
Collaborator Author

@sylveon long story... when I first built C++/WinRT and the DX library before it, the put functions were used heavily by the projection itself for binding ABI calls under the hood and injecting the cleanup code into every callsite was prohibitive. Today, C++/WinRT doesn't use those interop functions internally very much and its mainly used by app-level interop code where developers expect more from such helpers.

@kennykerr
Copy link
Collaborator Author

The build actually succeeded - seems to be a mix of Azure build and GitHub reporting issues.

@kennykerr kennykerr merged commit 00bc3b8 into master Jul 21, 2021
@kennykerr kennykerr deleted the put branch July 21, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.