Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@ChrisGuzak
Copy link
Member

(#860)

…mplementation (#860)

Co-authored-by: Chris Guzak (WINDOWS) <chrisg@ntdev.microsoft.com>
@ChrisGuzak
Copy link
Member Author

To verify it I hand patched tools\cppwinrt\Microsoft.Cpp.CppWinRTEnabled.targets and built the projects listed below. There were some link failures due to missing static lib dependencies (incomplete dependency info in the LDG) but these are unrelated to the change. The Terminal project was built successfully with this change.

Is this sufficient validation?

@kennykerr
Copy link
Collaborator

Kicked off a build.

@kennykerr kennykerr merged commit 969ea26 into master May 3, 2021
@kennykerr kennykerr deleted the user/chrisg/target branch May 3, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.