Harden operator wstring_view#546
Merged
Conversation
kennykerr
commented
Mar 3, 2020
| else | ||
| { | ||
| return {}; | ||
| return { L"", 0 }; |
Collaborator
Author
There was a problem hiding this comment.
When the hstring is empty, the wstring_view's default constructor causes the data member to return a nullptr as per the spec:
https://en.cppreference.com/w/cpp/string/basic_string_view/basic_string_view
Now instead, data will return an empty null-terminated string.
Scottj1s
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some existing code relies on data returning a valid string even when the view is empty.