Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove use of umbrella libraries#520

Merged
kennykerr merged 4 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
wjk:remove-umbrella-libswjk/cppwinrt:remove-umbrella-libsCopy head branch name to clipboard
Feb 5, 2020
Merged

Remove use of umbrella libraries#520
kennykerr merged 4 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
wjk:remove-umbrella-libswjk/cppwinrt:remove-umbrella-libsCopy head branch name to clipboard

Conversation

@wjk
Copy link
Contributor

@wjk wjk commented Feb 5, 2020

This reference was actually in the NuGet package, not the project templates.

Fixes #488.

Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nuget/CppWinrtRules.Project.xml Outdated Show resolved Hide resolved
@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@kennykerr kennykerr merged commit b26b1ad into microsoft:master Feb 5, 2020
@wjk wjk deleted the remove-umbrella-libs branch February 5, 2020 17:22
kennykerr added a commit that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all umbrella libs from project templates as they are unreliable

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.