Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support for x86 builds with Clang#511

Merged
kennykerr merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
kennykerr-clang-x86microsoft/cppwinrt:kennykerr-clang-x86Copy head branch name to clipboard
Feb 3, 2020
Merged

Support for x86 builds with Clang#511
kennykerr merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
kennykerr-clang-x86microsoft/cppwinrt:kennykerr-clang-x86Copy head branch name to clipboard

Conversation

@kennykerr
Copy link
Collaborator

Fixed #496

The Clang compiler still lacks the Visual C++ support for lambdas with stdcall calling convention. This update removes the use of those lambdas where calling convention matters so that the Clang compiler may be used to build x86 binaries.

@kennykerr kennykerr requested a review from Scottj1s February 3, 2020 13:56
Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, working with the nameof operator in C#, would be to locate the runtime functions in a "fallback" namespace and use __FUNCTION__ to avoid the string literals.

@kennykerr kennykerr merged commit 78da673 into master Feb 3, 2020
@kennykerr kennykerr deleted the kennykerr-clang-x86 branch February 3, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x86 clang compilation broken

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.