Fix overloads coming from overridable interfaces#1458
Merged
dmachaj merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Dec 4, 2024
sylveon:user/sylveon/produce-overloadsylveon/cppwinrt:user/sylveon/produce-overloadCopy head branch name to clipboard
Merged
Fix overloads coming from overridable interfaces#1458dmachaj merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom sylveon:user/sylveon/produce-overloadsylveon/cppwinrt:user/sylveon/produce-overloadCopy head branch name to clipboard
dmachaj merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
sylveon:user/sylveon/produce-overloadsylveon/cppwinrt:user/sylveon/produce-overloadCopy head branch name to clipboard
Conversation
dlech
added a commit
to pywinrt/TestWinRT
that referenced
this pull request
Nov 24, 2024
dlech
added a commit
to pywinrt/TestWinRT
that referenced
this pull request
Nov 24, 2024
dlech
added a commit
to pywinrt/TestWinRT
that referenced
this pull request
Nov 24, 2024
dmachaj
previously approved these changes
Nov 24, 2024
Contributor
dmachaj
left a comment
There was a problem hiding this comment.
This aspect of the projection is outside my area of expertise but from what I do understand this seems reasonable.
dmachaj
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1457