Latest vpack has an extra cppwinrt folder#1447
Merged
DefaultRyan merged 1 commit intomastermicrosoft/cppwinrt:masterfrom Nov 8, 2024
user/defaultryan/vpack-pathmicrosoft/cppwinrt:user/defaultryan/vpack-pathCopy head branch name to clipboard
Merged
Latest vpack has an extra cppwinrt folder#1447DefaultRyan merged 1 commit intomastermicrosoft/cppwinrt:masterfrom user/defaultryan/vpack-pathmicrosoft/cppwinrt:user/defaultryan/vpack-pathCopy head branch name to clipboard
DefaultRyan merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
user/defaultryan/vpack-pathmicrosoft/cppwinrt:user/defaultryan/vpack-pathCopy head branch name to clipboard
Conversation
dmachaj
approved these changes
Nov 8, 2024
walbourn
reviewed
Nov 8, 2024
| displayName: 'Stage compiler vpack contents' | ||
| inputs: | ||
| SourceFolder: $(Build.SourcesDirectory)/x86 | ||
| SourceFolder: $(Build.SourcesDirectory)/x86/cppwinrt |
Member
There was a problem hiding this comment.
This doesn't seem to be correct to me. If the source is built in $(Build.SourcesDirectory)/x86/cppwinrt then it has to be copied from there.
If what you want is the vpack contents laid out at the root for these files, shouldn't you just have added flattenFolders: true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to test the latest changes using a vpack, the latest vpacks are being built with an extra cppwinrt folder compared to previous vpacks. Unclear why this has changed, but it's been a long time since the last vpack was built, so any number of minor changes could have resulted in this.
Prior vPack contents:
Latest vPack contents:
This simply changes the vpack contents structure back to the prior format, to avoid needlessly churning the consuming build systems.