Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Value-init fields of WinRT structs (fix warning C24695 in generated code)#1443

Merged
DefaultRyan merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
user/defaultryan/init-struct-fieldsmicrosoft/cppwinrt:user/defaultryan/init-struct-fieldsCopy head branch name to clipboard
Oct 29, 2024
Merged

Value-init fields of WinRT structs (fix warning C24695 in generated code)#1443
DefaultRyan merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
user/defaultryan/init-struct-fieldsmicrosoft/cppwinrt:user/defaultryan/init-struct-fieldsCopy head branch name to clipboard

Conversation

@DefaultRyan
Copy link
Member

@DefaultRyan DefaultRyan commented Oct 29, 2024

Current codegen was triggering Warning C24695 - Variable 'foo' is uninitialized.

This adds a default initializer to struct fields.

Before:

namespace winrt::Windows::UI::Xaml::Interop
{
    struct TypeName
    {
        hstring Name;
        winrt::Windows::UI::Xaml::Interop::TypeKind Kind;
    };
}

After:

namespace winrt::Windows::UI::Xaml::Interop
{
    struct TypeName
    {
        hstring Name {};
        winrt::Windows::UI::Xaml::Interop::TypeKind Kind {};
    };
}

Since consume* methods that return a struct are already value-initializing the return value, this has a negligible effect on the compiler codegen there. So that's nice.

@DefaultRyan DefaultRyan requested a review from Scottj1s October 29, 2024 18:00
@DefaultRyan DefaultRyan merged commit 2744f5c into master Oct 29, 2024
@DefaultRyan DefaultRyan deleted the user/defaultryan/init-struct-fields branch October 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr kennykerr approved these changes

@Scottj1s Scottj1s Scottj1s approved these changes

@dmachaj dmachaj dmachaj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DefaultRyan @kennykerr @Scottj1s @dmachaj
Morty Proxy This is a proxified and sanitized view of the page, visit original site.