Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Changed visibility of observable_map_base::call_changed to protected#1425

Merged
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
Patschkowski:masterPatschkowski/cppwinrt:masterCopy head branch name to clipboard
Jul 11, 2024
Merged

Changed visibility of observable_map_base::call_changed to protected#1425
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
Patschkowski:masterPatschkowski/cppwinrt:masterCopy head branch name to clipboard

Conversation

@Patschkowski
Copy link
Contributor

@Patschkowski Patschkowski commented Jul 10, 2024

This matches the visibility of observable_vector_base::call_changed to enable derived classes to raise change notifications when the underlying container changes.

Fixes: #1422

…to match the visibility of observable_vector_base::call_changed to enabled derived classes to raise change notifications when the underlying container changes.
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennykerr kennykerr changed the title Changed visibility of observable_map_base::call_changed to protected … Changed visibility of observable_map_base::call_changed to protected Jul 11, 2024
@kennykerr kennykerr merged commit 4834e60 into microsoft:master Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: observable_map_base::call_changed is private

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.