Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix build following dependabot updates#1409

Merged
kennykerr merged 3 commits intomastermicrosoft/cppwinrt:masterfrom
test-buildmicrosoft/cppwinrt:test-buildCopy head branch name to clipboard
Apr 5, 2024
Merged

Fix build following dependabot updates#1409
kennykerr merged 3 commits intomastermicrosoft/cppwinrt:masterfrom
test-buildmicrosoft/cppwinrt:test-buildCopy head branch name to clipboard

Conversation

@kennykerr
Copy link
Collaborator

Dependabot updates seem to have hit this issue:

actions/upload-artifact#478

Let's see if it can recover...

@kennykerr kennykerr changed the title Test build following dependabot updates Fix build following dependabot updates Apr 5, 2024
@kennykerr kennykerr merged commit 17d095a into master Apr 5, 2024
@kennykerr kennykerr deleted the test-build branch April 5, 2024 14:39
@jsoref
Copy link
Contributor

jsoref commented Apr 5, 2024

Correct, ideally your CI and dependabot should have recognized that the workflow requires both download-artifact and upload-artifact to be updated at the same time. Because they weren't, there was no way this could possibly have worked.

Beyond that, in order to upgrade a workflow that uses upload-artifact as part of a matrix, the workflow will need to be reworked (which isn't something dependabot would ever do).

As you're using a matrix, you might have considered:
https://github.com/actions/upload-artifact/blob/main/merge/README.md#examples

But the real culprit is that your matrix has 3 dimensions and your artifact upload/download only use two, as such this job/matrix element

https://github.com/microsoft/cppwinrt/actions/runs/8570372218/job/23488155109

Performed:

Run actions/upload-artifact@v4
  with:
    name: msvc-build-x64-Debug-bin

While https://github.com/microsoft/cppwinrt/actions/runs/8570372218/job/23488155949#step:11:1 wanted to perform the same.

The "fix" would be to change:

name: msvc-build-${{ matrix.arch }}-${{ matrix.config }}-bin

- name: msvc-build-${{ matrix.arch }}-${{ matrix.config }}-bin 
+ name: msvc-build-${{ matrix.compiler }}-${{ matrix.arch }}-${{ matrix.config }}-bin 

(You'll have to make the change to each side of upload/download artifacts)

@kennykerr
Copy link
Collaborator Author

Thanks! I'm not too familiar with the workflow, so I really appreciate you taking a look. Will give this a try.

@jsoref
Copy link
Contributor

jsoref commented Apr 5, 2024

I've put some untested changes into https://github.com/check-spelling-sandbox/cppwinrt/tree/unique-matrix-artifacts but it looks like it'd take me a bit to actually trigger stuff...

@jsoref
Copy link
Contributor

jsoref commented Apr 5, 2024

This run w/ the penciled steps seems to work (at least it gets past the first fault):
https://github.com/check-spelling-sandbox/cppwinrt/actions/runs/8572837925/job/23496284366

This run tries to use the v4 version of things (but I'm going to run into contention as I don't have an infinite supply of runners)
https://github.com/check-spelling-sandbox/cppwinrt/actions/runs/8572877150/job/23496405260

@kennykerr
Copy link
Collaborator Author

kennykerr commented Apr 5, 2024

Feel free to send a PR this way and we can run it to test as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.