Update GitHub action LLVM version to 17.0.5#1373
Merged
jonwis merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Nov 26, 2023
jonwis:user/jonwis/llvm-version-updatejonwis/cppwinrt:user/jonwis/llvm-version-updateCopy head branch name to clipboard
Merged
Update GitHub action LLVM version to 17.0.5#1373jonwis merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom jonwis:user/jonwis/llvm-version-updatejonwis/cppwinrt:user/jonwis/llvm-version-updateCopy head branch name to clipboard
jonwis merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
jonwis:user/jonwis/llvm-version-updatejonwis/cppwinrt:user/jonwis/llvm-version-updateCopy head branch name to clipboard
Conversation
Member
Author
|
A new and interesting errro! |
Member
Author
|
Turns out that LLVM 17.0.5 resolved this complaint: cppwinrt/test/test_cpp20/custom_error.cpp Lines 38 to 42 in bf4459b ... so the test metadata needs to be updated to say that clang is no longer "!shouldfail" |
Member
Author
|
Notably, the test_component component does not build correctly here: At least on my machine, the A problem for another day. |
kennykerr
approved these changes
Nov 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1372 it looks like the build VMs were updated to a more recent VS and VCRT and STL combination, requiring an updated LLVM toolchain. This bumps the target LLM version to match.