Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove old Windows 7 support code#1348

Merged
kennykerr merged 3 commits intomastermicrosoft/cppwinrt:masterfrom
win7microsoft/cppwinrt:win7Copy head branch name to clipboard
Aug 28, 2023
Merged

Remove old Windows 7 support code#1348
kennykerr merged 3 commits intomastermicrosoft/cppwinrt:masterfrom
win7microsoft/cppwinrt:win7Copy head branch name to clipboard

Conversation

@kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Aug 25, 2023

As a reminder, whatever Windows 7 compatibility was previously provided is still available via older versions of the C++/WinRT nuget package.

Fixes: #1344

@kennykerr
Copy link
Collaborator Author

kennykerr commented Aug 25, 2023

I've also removed tests that rely on GNU to build since their import libs don't include some Windows 8 exports. We can decide what to ultimately do about that here: #1341

The cppwinrt compiler continues to be cross compiled and both MSVC and Clang are tested on Windows.

@alvinhochun
Copy link
Contributor

alvinhochun commented Aug 26, 2023

I believe the mingw-w64 link errors can be fixed by adding combase to the link libraries.

Edit: It probably should be runtimeobject instead... but will have to test it to be sure.
Yeah probably, I did add that for test and old_tests.

@kennykerr kennykerr merged commit de6ca88 into master Aug 28, 2023
@kennykerr kennykerr deleted the win7 branch August 28, 2023 13:35
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old Windows 7 support code

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.