Support for std::span for winrt::array_view and winrt::com_array#1343
Merged
jonwis merged 8 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Aug 28, 2023
jonwis:user/jonwis/update-juv-studiosjonwis/cppwinrt:user/jonwis/update-juv-studiosCopy head branch name to clipboard
Merged
Support for std::span for winrt::array_view and winrt::com_array#1343jonwis merged 8 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom jonwis:user/jonwis/update-juv-studiosjonwis/cppwinrt:user/jonwis/update-juv-studiosCopy head branch name to clipboard
jonwis merged 8 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
jonwis:user/jonwis/update-juv-studiosjonwis/cppwinrt:user/jonwis/update-juv-studiosCopy head branch name to clipboard
Conversation
sylveon
reviewed
Aug 20, 2023
jaigak
reviewed
Aug 20, 2023
Collaborator
|
Hopefully @DefaultRyan can spare a few minutes to look this over. He probably has the best handle on the standard library best practices. |
kennykerr
reviewed
Aug 21, 2023
kennykerr
approved these changes
Aug 28, 2023
Collaborator
kennykerr
left a comment
There was a problem hiding this comment.
I still think the lifetime here is bonkers, but admittedly not any worse than the C++ standard library.
Contributor
|
Sorry I'm a little late to the party. Do these new methods affect vtable layout at all? In other words, does span support need an ODR pragma to prevent mismatches? |
Collaborator
|
Member
Author
|
It's pure conversion methods; no change to the layout or functionality of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1289 per "option C" by completing what #1331 started.
@JaiganeshKumaran thank you for the initial start - see if this meets your needs, please.