Fix cpp20 source location test failure resulting from newer compiler#1326
Merged
kennykerr merged 3 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Jun 22, 2023
dmachaj:user/dmachaj/fix-cpp20-test-casedmachaj/cppwinrt:user/dmachaj/fix-cpp20-test-caseCopy head branch name to clipboard
Merged
Fix cpp20 source location test failure resulting from newer compiler#1326kennykerr merged 3 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom dmachaj:user/dmachaj/fix-cpp20-test-casedmachaj/cppwinrt:user/dmachaj/fix-cpp20-test-caseCopy head branch name to clipboard
kennykerr merged 3 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
dmachaj:user/dmachaj/fix-cpp20-test-casedmachaj/cppwinrt:user/dmachaj/fix-cpp20-test-caseCopy head branch name to clipboard
Conversation
Contributor
|
Would it make more sense to validate that functionNameSv contains the name of the function instead of using a strict == |
… be more stable over time
Contributor
Author
That's a good point. That should still provide the validation we need while also being far more stable. Great suggestion 👍 |
kennykerr
reviewed
Jun 22, 2023
kennykerr
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this all about?
Fix a test case failure caused by changing compiler behavior in a newer compiler version. The signature that MSVC provides for source_location has changed recently.
Instead of chasing the full decorated name, with each compiler having a slight variation, we now match just the meaningful substring that we care about "FailOnLine15". This should now be stable across compilers and across compiler versions.
Fixes: #1325