Add capture support for unconventional result types#1301
Merged
Add capture support for unconventional result types#1301
capture support for unconventional result types#1301Conversation
jonwis
previously approved these changes
Apr 28, 2023
sylveon
reviewed
Apr 28, 2023
…into capture_decay
Member
|
I was originally worried that this might be too permissive. There are some methods that take a REFIID followed by something that isn't the matched output pointer. However, they are exceedingly rare, and the only one that does it at the end of the parameter list that I could find (mind you, I gave up halfway through the D's) is IDebugProperty::EnumMembers, so I concluded that the very low risk wasn't worth the extra protection. Unit test needs to include the forwarder pattern: com_ptr<ICapture> f = capture<ICapture>([&](auto riid, auto ppv) { return CreateCapture2(10, riid, ppv); });This pattern is used to accommodate methods that don't put the riid/ppv as the last two parameters. HRESULT WeirdMethod(REFIID riid, char const* interloper, IUnknown** result, int straggler);
e.capture<IUnknown>(WeirdMethod, [](auto interloper, auto straggler, auto riid, auto result) { return WeirdMethod(riid, interloper, result, straggler); }, "interloper", 10); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1299