Fix unreliable clock epoch tests#1277
Merged
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Feb 17, 2023
Merged
Fix unreliable clock epoch tests#1277kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
Conversation
The clock epoch tests are sensitive to CPU speed and the precise moment the clock ticks over from one second to another. Change the way we do epoch tests so that they are not affected by either factor. This fixes a spurious CI test failure where the test environment was 3 milliseconds too slow. https://github.com/oldnewthing/cppwinrt/actions/runs/4195918696/jobs/7276654213
kennykerr
approved these changes
Feb 17, 2023
Collaborator
kennykerr
left a comment
There was a problem hiding this comment.
Thanks for fixing this annoyance!
Collaborator
|
A few more unreliable tests... https://github.com/microsoft/cppwinrt/actions/runs/4208012719 🙄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clock epoch tests are sensitive to CPU speed and the precise moment the clock ticks over from one second to another. Change the way we do epoch tests so that they are not affected by either factor.
This fixes a spurious CI test failure where the test environment was 3 milliseconds too slow.
https://github.com/oldnewthing/cppwinrt/actions/runs/4195918696/jobs/7276654213