Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Workaround for false positive code analysis warning#1269

Merged
kennykerr merged 3 commits intomastermicrosoft/cppwinrt:masterfrom
ca-workaroundmicrosoft/cppwinrt:ca-workaroundCopy head branch name to clipboard
Feb 6, 2023
Merged

Workaround for false positive code analysis warning#1269
kennykerr merged 3 commits intomastermicrosoft/cppwinrt:masterfrom
ca-workaroundmicrosoft/cppwinrt:ca-workaroundCopy head branch name to clipboard

Conversation

@kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Feb 3, 2023

The issue is that the code analysis engine doesn't realize - it doesn't look at the implementation - that the pointer stored within the com_ptr is actually checked for validity before proceeding.

Fixes #1267

@kennykerr kennykerr requested a review from oldnewthing February 3, 2023 16:49
Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping back in!

@kennykerr kennykerr merged commit 3bbee2c into master Feb 6, 2023
@kennykerr kennykerr deleted the ca-workaround branch February 6, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implements class template triggers false positive code analysis warning

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.