Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move build pipeline into YAML#1268

Merged
DefaultRyan merged 10 commits intomastermicrosoft/cppwinrt:masterfrom
user/defaultryan/yamlmicrosoft/cppwinrt:user/defaultryan/yamlCopy head branch name to clipboard
Feb 1, 2023
Merged

Move build pipeline into YAML#1268
DefaultRyan merged 10 commits intomastermicrosoft/cppwinrt:masterfrom
user/defaultryan/yamlmicrosoft/cppwinrt:user/defaultryan/yamlCopy head branch name to clipboard

Conversation

@DefaultRyan
Copy link
Member

Among other things, this will allow the C++/WinRT build pipeline to stay synchronized with the product code.

build.yaml contains the same build steps as the original classic pipeline. Here's a test run. https://microsoft.visualstudio.com/Dart/_build/results?buildId=63658741&view=results

kennykerr
kennykerr previously approved these changes Jan 31, 2023
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@kennykerr
Copy link
Collaborator

image

Weird that it seems to be "failing" because of a prior run:

image

Might just be some weird sync between GitHub and Azure.

.pipelines/build.yml Show resolved Hide resolved
.pipelines/build.yml Outdated Show resolved Hide resolved
.pipelines/build.yml Outdated Show resolved Hide resolved
.pipelines/build.yml Outdated Show resolved Hide resolved
.pipelines/build.yml Outdated Show resolved Hide resolved
@kennykerr kennykerr self-requested a review January 31, 2023 17:50
@kennykerr kennykerr dismissed their stale review January 31, 2023 17:50

See David's feedback

@DefaultRyan DefaultRyan requested a review from dmachaj January 31, 2023 19:46
dmachaj
dmachaj previously approved these changes Jan 31, 2023
@DefaultRyan
Copy link
Member Author

The microsoft.cppwinrt build is hitting some weird NuGet timeout issues. Not related to this change.

@DefaultRyan DefaultRyan merged commit d68a8c7 into master Feb 1, 2023
@DefaultRyan DefaultRyan deleted the user/defaultryan/yaml branch February 1, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.