Make headers partially usable with LLVM/libc++ 13#1257
Merged
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Jan 3, 2023
Merged
Make headers partially usable with LLVM/libc++ 13#1257kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
Conversation
This works around a compile error due to the floating point version of `std::to_chars` not implemented in libc++ 13, so that C++/WinRT can be used on LLVM 13 with limited support. It should work as long as none of the functions involving coroutines are used.
kennykerr
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around a compile error due to the floating point version of
std::to_charsnot implemented in libc++ 13, so that C++/WinRT can be used on LLVM 13 with limited support. It should work as long as none of the functions involving coroutines are used.