Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

cmake: Allow using external winmd headers to bypass download#1256

Merged
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/winmd-overridealvinhochun/cppwinrt:alvin/winmd-overrideCopy head branch name to clipboard
Jan 3, 2023
Merged

cmake: Allow using external winmd headers to bypass download#1256
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/winmd-overridealvinhochun/cppwinrt:alvin/winmd-overrideCopy head branch name to clipboard

Conversation

@alvinhochun
Copy link
Contributor

When integrating cppwinrt from another project, I want to vendor the winmd headers into the source tree to avoid performing the download during build. This change adds a EXTERNAL_WINMD_INCLUDE_DIR variable to enable this usage.

@sylveon
Copy link
Contributor

sylveon commented Jan 2, 2023

This sounds ripe for trouble because of the pragma detect_mismatch included in the header. Every consumer is now locked in to this exact version of cppwinrt.

Edit: misread the change, thought it was for vendoring in cppwinrt.

@kennykerr kennykerr merged commit 0214f2f into microsoft:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.