cppwinrt: Support Linux cross-build with mingw-w64#1238
Merged
kennykerr merged 11 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Nov 28, 2022
alvinhochun:alvin/cross-buildalvinhochun/cppwinrt:alvin/cross-buildCopy head branch name to clipboard
Merged
cppwinrt: Support Linux cross-build with mingw-w64#1238kennykerr merged 11 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom alvinhochun:alvin/cross-buildalvinhochun/cppwinrt:alvin/cross-buildCopy head branch name to clipboard
kennykerr merged 11 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/cross-buildalvinhochun/cppwinrt:alvin/cross-buildCopy head branch name to clipboard
Conversation
_get_pgmptr is not available in msvcrt used by most mingw-w64 toolchains, so use GetModuleFileNameA instead. I also found that _get_pgmptr does not give a path at all when run from a long path (>260 bytes) so this change will be an improvement.
32KB on the stack isn't really that bad...
This reverts commit 735c85f.
Contributor
Author
|
Getting random intermittent failures again... @kennykerr can you please trigger a re-run of the failed jobs? |
Merged
kennykerr
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables cross-building the cppwinrt.exe tool from Linux. A CI has been added to test this.