Partial GCC compatibility improvements by alvinhochun · Pull Request #1234 · microsoft/cppwinrt

alvinhochun · Nov 21, 2022

Generated headers do not actually work on GCC.

This implements some changes intended to improve compatibility with GCC 12. However, there is an 8-year-old upstream defect which stops winrt::impl::bind_in from compiling:

GCC 12 Compile Error

In file included from C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.Collections.h:9,
                 from D:/cppwinrt/test/test/pch.h:9,
                 from C:/msys64/home/Alvin/cppwinrt/test/test/CMakeFiles/test-vanilla.dir/cmake_pch.hxx:5,
                 from <command-line>:
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h: In instantiation of 'auto winrt::impl::consume_Windows_Foundation_IPropertyValueStatics<D>::CreateGuid(const winrt::guid&) const [with D = winrt::Windows::Foundation::IPropertyValueStatics]':
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:2193:130:   required from here
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:472:108: error: cannot convert 'winrt::impl::bind_in<winrt::guid>' to 'winrt::guid'
  472 |         check_hresult(WINRT_IMPL_SHIM(winrt::Windows::Foundation::IPropertyValueStatics)->CreateGuid(impl::bind_in(value), &propertyValue));
      |                                                                                                            ^~~~~~~~~~~~~~
      |                                                                                                            |
      |                                                                                                            winrt::impl::bind_in<winrt::guid>
In file included from C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.1.h:7,
                 from C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.2.h:7,
                 from C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:10:
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.0.h:418:50: note:   initializing argument 1 of 'virtual int32_t winrt::impl::abi<winrt::Windows::Foundation::IPropertyValueStatics>::type::CreateGuid(winrt::guid, void**)'
  418 |             virtual int32_t __stdcall CreateGuid(winrt::guid, void**) noexcept = 0;
      |                                                  ^~~~~~~~~~~
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h: In instantiation of 'auto winrt::impl::consume_Windows_Foundation_IPropertyValueStatics<D>::CreateDateTime(const winrt::Windows::Foundation::DateTime&) const [with D = winrt::Windows::Foundation::IPropertyValueStatics; winrt::Windows::Foundation::DateTime = std::chrono::time_point<winrt::clock, std::chrono::duration<long long int, std::ratio<1, 10000000> > >]':
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:2197:134:   required from here
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:478:112: error: cannot convert 'winrt::impl::bind_in<std::chrono::time_point<winrt::clock, std::chrono::duration<long long int, std::ratio<1, 10000000> > > >'
 to 'int64_t' {aka 'long long int'}
  478 |         check_hresult(WINRT_IMPL_SHIM(winrt::Windows::Foundation::IPropertyValueStatics)->CreateDateTime(impl::bind_in(value), &propertyValue));
      |                                                                                                                ^~~~~~~~~~~~~~
      |                                                                                                                |
      |                                                                                                                winrt::impl::bind_in<std::chrono::time_point<winrt::clock, std::chrono::duration<long long int, std::ratio<1,
10000000> > > >
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.0.h:419:54: note:   initializing argument 1 of 'virtual int32_t winrt::impl::abi<winrt::Windows::Foundation::IPropertyValueStatics>::type::CreateDateTime(int64_t, void**)'
  419 |             virtual int32_t __stdcall CreateDateTime(int64_t, void**) noexcept = 0;
      |                                                      ^~~~~~~
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h: In instantiation of 'auto winrt::impl::consume_Windows_Foundation_IPropertyValueStatics<D>::CreateTimeSpan(const winrt::Windows::Foundation::TimeSpan&) const [with D = winrt::Windows::Foundation::IPropertyValueStatics; winrt::Windows::Foundation::TimeSpan = std::chrono::duration<long long int, std::ratio<1, 10000000> >]':
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:2201:134:   required from here
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:484:112: error: cannot convert 'winrt::impl::bind_in<std::chrono::duration<long long int, std::ratio<1, 10000000> > >' to 'int64_t' {aka 'long long int'}
  484 |         check_hresult(WINRT_IMPL_SHIM(winrt::Windows::Foundation::IPropertyValueStatics)->CreateTimeSpan(impl::bind_in(value), &propertyValue));
      |                                                                                                                ^~~~~~~~~~~~~~
      |                                                                                                                |
      |                                                                                                                winrt::impl::bind_in<std::chrono::duration<long long int, std::ratio<1, 10000000> > >
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.0.h:420:54: note:   initializing argument 1 of 'virtual int32_t winrt::impl::abi<winrt::Windows::Foundation::IPropertyValueStatics>::type::CreateTimeSpan(int64_t, void**)'
  420 |             virtual int32_t __stdcall CreateTimeSpan(int64_t, void**) noexcept = 0;
      |                                                      ^~~~~~~
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h: In instantiation of 'auto winrt::impl::consume_Windows_Foundation_IPropertyValueStatics<D>::CreatePoint(const winrt::Windows::Foundation::Point&) const [with D = winrt::Windows::Foundation::IPropertyValueStatics]':
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:2205:131:   required from here
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:490:109: error: cannot convert 'winrt::impl::bind_in<winrt::Windows::Foundation::Point>' to 'winrt::Windows::Foundation::Point'
  490 |         check_hresult(WINRT_IMPL_SHIM(winrt::Windows::Foundation::IPropertyValueStatics)->CreatePoint(impl::bind_in(value), &propertyValue));
      |                                                                                                             ^~~~~~~~~~~~~~
      |                                                                                                             |
      |                                                                                                             winrt::impl::bind_in<winrt::Windows::Foundation::Point>
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.0.h:421:51: note:   initializing argument 1 of 'virtual int32_t winrt::impl::abi<winrt::Windows::Foundation::IPropertyValueStatics>::type::CreatePoint(winr
t::Windows::Foundation::Point, void**)'
  421 |             virtual int32_t __stdcall CreatePoint(winrt::Windows::Foundation::Point, void**) noexcept = 0;
      |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h: In instantiation of 'auto winrt::impl::consume_Windows_Foundation_IPropertyValueStatics<D>::CreateSize(const winrt::Windows::Foundation::Size&) const [with D = winrt::Windows::Foundation::IPropertyValueStatics]':
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:2209:130:   required from here
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:496:108: error: cannot convert 'winrt::impl::bind_in<winrt::Windows::Foundation::Size>' to 'winrt::Windows::Foundation::Size'
  496 |         check_hresult(WINRT_IMPL_SHIM(winrt::Windows::Foundation::IPropertyValueStatics)->CreateSize(impl::bind_in(value), &propertyValue));
      |                                                                                                            ^~~~~~~~~~~~~~
      |                                                                                                            |
      |                                                                                                            winrt::impl::bind_in<winrt::Windows::Foundation::Size>
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.0.h:422:50: note:   initializing argument 1 of 'virtual int32_t winrt::impl::abi<winrt::Windows::Foundation::IPropertyValueStatics>::type::CreateSize(winrt::Windows::Foundation::Size, void**)'
  422 |             virtual int32_t __stdcall CreateSize(winrt::Windows::Foundation::Size, void**) noexcept = 0;
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h: In instantiation of 'auto winrt::impl::consume_Windows_Foundation_IPropertyValueStatics<D>::CreateRect(const winrt::Windows::Foundation::Rect&) const [with D = winrt::Windows::Foundation::IPropertyValueStatics]':
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:2213:130:   required from here
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/Windows.Foundation.h:502:108: error: cannot convert 'winrt::impl::bind_in<winrt::Windows::Foundation::Rect>' to 'winrt::Windows::Foundation::Rect'
  502 |         check_hresult(WINRT_IMPL_SHIM(winrt::Windows::Foundation::IPropertyValueStatics)->CreateRect(impl::bind_in(value), &propertyValue));
      |                                                                                                            ^~~~~~~~~~~~~~
      |                                                                                                            |
      |                                                                                                            winrt::impl::bind_in<winrt::Windows::Foundation::Rect>
C:/msys64/home/Alvin/cppwinrt/test/cppwinrt/winrt/impl/Windows.Foundation.0.h:423:50: note:   initializing argument 1 of 'virtual int32_t winrt::impl::abi<winrt::Windows::Foundation::IPropertyValueStatics>::type::CreateRect(winrt::Windows::Foundation::Rect, void**)'
  423 |             virtual int32_t __stdcall CreateRect(winrt::Windows::Foundation::Rect, void**) noexcept = 0;
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Unless the issue can be worked around by changing the implementation of winrt::impl::bind_in, I don't see cppwinrt being usable with GCC any time soon. (CC @Biswa96)

`#include <version>` is needed before using `__cpp_lib_coroutine`, but it is technically only available since C++20.

alvinhochun and others added 5 commits November 21, 2022 18:29

Add missing includes for GCC 12

4c9c94b

Fix coroutine support check for GCC 12 and improve error reporting

b34c5e0

`#include <version>` is needed before using `__cpp_lib_coroutine`, but it is technically only available since C++20.

winrt::clock: Add time_point_cast for GCC 12

59e4607

Specify std namespace when using nullptr_t

70a9a4e

Merge branch 'master' into alvin/gcc12

7f74c15

kennykerr approved these changes Nov 21, 2022

View reviewed changes

kennykerr merged commit 530d383 into microsoft:master Nov 21, 2022

alvinhochun mentioned this pull request Dec 11, 2022

Make compatible with GCC #1245

Merged

alvinhochun deleted the alvin/gcc12 branch December 11, 2022 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partial GCC compatibility improvements#1234

Partial GCC compatibility improvements#1234
kennykerr merged 5 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/gcc12alvinhochun/cppwinrt:alvin/gcc12Copy head branch name to clipboard

alvinhochun commented Nov 21, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Conversation

alvinhochun commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alvinhochun commented Nov 21, 2022 •

edited

Loading