Fix formatting primitive types such as integers#1231
Merged
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Nov 21, 2022
sylveon:user/sylveon/int-winrt-formatsylveon/cppwinrt:user/sylveon/int-winrt-formatCopy head branch name to clipboard
Merged
Fix formatting primitive types such as integers#1231kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom sylveon:user/sylveon/int-winrt-formatsylveon/cppwinrt:user/sylveon/int-winrt-formatCopy head branch name to clipboard
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
sylveon:user/sylveon/int-winrt-formatsylveon/cppwinrt:user/sylveon/int-winrt-formatCopy head branch name to clipboard
Conversation
kennykerr
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With std::format reference semantics are only used for user defined types so without std::forward you somehow can't format integers. Forwarding twice is safe because objects are not copied/moved from during formatting.
Would like a quick release of this fix because it's breaking my scenario.