Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix multi_threaded_map/_vector tests on Clang#1230

Merged
kennykerr merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/mingw-testsalvinhochun/cppwinrt:alvin/mingw-testsCopy head branch name to clipboard
Nov 21, 2022
Merged

Fix multi_threaded_map/_vector tests on Clang#1230
kennykerr merged 2 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/mingw-testsalvinhochun/cppwinrt:alvin/mingw-testsCopy head branch name to clipboard

Conversation

@alvinhochun
Copy link
Contributor

Removed one bit of enable_if_t metaprogramming that doesn't build with Clang and seems to be unneeded. The error message is:

enable_if.h:26:78: error: no type named 'type' in 'std::enable_if<false>'; 'enable_if' cannot be used to disable this declaration
template <bool _Bp, class _Tp = void> using enable_if_t = typename enable_if<_Bp, _Tp>::type;
                                                                             ^~~
multi_threaded_common.h:155:34: note: in instantiation of template type alias 'enable_if_t' requested here
        template<typename = std::enable_if_t<!std::is_same_v<ConvertibleFrom, void>>>
                                 ^
[snip]

@kennykerr kennykerr merged commit e96613d into microsoft:master Nov 21, 2022
@alvinhochun alvinhochun deleted the alvin/mingw-tests branch December 11, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.