Enable more tests on llvm-mingw and some fixes#1229
Merged
kennykerr merged 6 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Nov 18, 2022
alvinhochun:alvin/mingw-testsalvinhochun/cppwinrt:alvin/mingw-testsCopy head branch name to clipboard
Merged
Enable more tests on llvm-mingw and some fixes#1229kennykerr merged 6 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom alvinhochun:alvin/mingw-testsalvinhochun/cppwinrt:alvin/mingw-testsCopy head branch name to clipboard
kennykerr merged 6 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
alvinhochun:alvin/mingw-testsalvinhochun/cppwinrt:alvin/mingw-testsCopy head branch name to clipboard
Conversation
Some test cases relies on error messages being in English and would otherwise fail on non-English systems.
This is needed for cross-building from Linux with mingw-w64.
sylveon
reviewed
Nov 17, 2022
| co_await context; | ||
| } | ||
|
|
||
| // Not yet buildable on mingw-w64. The lambda needs to have __stdcall |
Contributor
There was a problem hiding this comment.
Since this lambda has no captures, it can be converted to a normal function with __stdcall.
Contributor
Author
There was a problem hiding this comment.
That can work though it's not as clean as it currently is. However, the test that actually requires this code cannot be built due to missing __uuidof(IContextCallback) (which has been fixed on mingw-w64 upstream, but the current llvm-mingw 15 toolchain doesn't have the fix), so there is no harm just leaving this out for now.
kennykerr
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes include:
windowsnumerics.impl.hheader has been added to mingw-w64 recently, we can enable the tests that depend on it. If it is not available in the current mingw-w64 toolchain, there is an option to download a copy of it from the mingw-w64 git repo to allow these tests to run.test_cpp20andtest_oldfor llvm-mingw.test_oldin particular depends onwindowsnumerics.impl.h)