Projects with a nested Windows namespace (e.g., Microsoft::Windows) fail to compile#1223
Merged
Scottj1s merged 1 commit intomastermicrosoft/cppwinrt:masterfrom Nov 4, 2022
scottj1s/fully_qualify_windows_namespacemicrosoft/cppwinrt:scottj1s/fully_qualify_windows_namespaceCopy head branch name to clipboard
Merged
Projects with a nested Windows namespace (e.g., Microsoft::Windows) fail to compile#1223Scottj1s merged 1 commit intomastermicrosoft/cppwinrt:masterfrom scottj1s/fully_qualify_windows_namespacemicrosoft/cppwinrt:scottj1s/fully_qualify_windows_namespaceCopy head branch name to clipboard
Scottj1s merged 1 commit intomastermicrosoft/cppwinrt:masterfrom
scottj1s/fully_qualify_windows_namespacemicrosoft/cppwinrt:scottj1s/fully_qualify_windows_namespaceCopy head branch name to clipboard
Conversation
Member
Author
|
Fixes build errors: ...\winrt\Microsoft.UI.Xaml.Markup.h(1278,53): Error C3083: 'Foundation': the symbol to the left of a '::' must be a type |
kennykerr
approved these changes
Nov 4, 2022
Contributor
|
Would you mind adding the fix for microsoft/WindowsAppSDK#1901 as well while we're on the topic of nested Windows namespaces? |
Contributor
|
Also, maybe a unit test for this scenario would be desirable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered with WinUI-PR pipeline run: update versions for CppWinRT, wil, BuildTools, .NET runtime