Enable classic COM on mingw-w64#1215
Merged
kennykerr merged 4 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Oct 24, 2022
Merged
Enable classic COM on mingw-w64#1215kennykerr merged 4 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
kennykerr merged 4 commits intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
Conversation
Mingw-w64 does not use `__declspec(uuid(x))` but has its own way of supporting `__uuidof` by defining UUIDs with a special macro `__CRT_UUID_DECL`, which does actually work here.
Collaborator
|
Here we are again with classic COM. 😅 @sylveon do you want to take a stab at reviewing this, given your recent overhaul of this code? |
Contributor
|
From a quick read, it appears that everything is fine here. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mingw-w64 does not use
__declspec(uuid(x))but has its own way of supporting__uuidofby defining UUIDs with a special macro__CRT_UUID_DECL, which does actually work here.