Don't use __uuidof without GUID#1180
Merged
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom Sep 8, 2022
Merged
Don't use __uuidof without GUID#1180kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
kennykerr merged 1 commit intomicrosoft:mastermicrosoft/cppwinrt:masterfrom
Conversation
If GUID is not defined, then don't breathe the name of the `__uuidof` intrinsic, because that would instantiate an undefined structure. clang is stricter about this than msvc, but fix both just in case.
Member
Author
|
The hardest part about this fix is getting clang installed and consumed. I had to hack it because somebody is adding Also, the Directory.build.props is hard-coded to |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
reviewed
Sep 7, 2022
kennykerr
approved these changes
Sep 7, 2022
Contributor
|
It should be possible to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If GUID is not defined, then don't breathe the name of the
__uuidofintrinsic, because that would instantiate an undefined structure. clang is stricter about this than msvc, but fix both just in case.Fixes #1179