fix: schema input type member default init error on clang 14#310
Merged
wravery merged 1 commit intomicrosoft:mainmicrosoft/cppgraphqlgen:mainfrom Sep 9, 2024
Merged
fix: schema input type member default init error on clang 14#310wravery merged 1 commit intomicrosoft:mainmicrosoft/cppgraphqlgen:mainfrom
wravery merged 1 commit intomicrosoft:mainmicrosoft/cppgraphqlgen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same issue exists in the schema input types as in the client input types, although I never actually saw that with any of the schema samples.
The error I saw once with clang 14 on an
Ubuntu 22.04derived image (Pop OS!, specifically) had to do with not having a constructor for nested input type members available in the header when compiling the default member initializers using{}at the end of the member declaration. Since we've already pulled the default constructor for the type itself into the source file to fix ODR violations, it makes sense to move the default member initialization into the constructor's initializer list.